Migrate to gopkg.in/yaml.v3
#37553
Open
Migrate to gopkg.in/yaml.v3
#37553
+85
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L3n41c
requested review from
a team,
djaglowski,
andrzej-stencel,
dashpole,
atoulme,
dmitryax,
jpkrohling,
mx-psi and
songy23
as code owners
github-actions
bot
added
confmap/provider/s3provider
exporter/datadog
github-actions
bot
requested review from
armstrmi,
ArthurSens,
cparkins,
dehaansa,
dineshg13,
IbraheemA,
jade-guiton-dd,
liustanley,
mackjmr,
pjanotti,
schmikei,
sinkingpoint and
sumo-drosiek
songy23
added
dependencies
songy23
reviewed
Jan 28, 2025
There was a problem hiding this comment.
http://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13016551141/job/36309765881?pr=37553 seems you need to fix some indentations in tests
…tor-contrib into yaml.v3
1 task
pjanotti
approved these changes
Jan 28, 2025
mx-psi
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
I'm trying to understand the implications of this change, given that moving from yaml.v2 to yaml.v3 does have some breaking changes https://ubuntu.com/blog/api-v3-of-the-yaml-package-for-go-is-available. Examples: not allowing integers for durations, enforcing unique keys. They are probably not common, but still may cause errors for configurations that previously did not error out.
If I understand correctly, this PR introduces potentially functional changes to the following components:
- S3 provider - affects how the provider unmarshals configurations from YAML files in S3 https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.118.0/confmap/provider/s3provider/provider.go#L108.
- ECS observer - affects how YAML is marshaled to
result_filehttps://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.118.0/extension/observer/ecsobserver/target.go#L179. - Prometheus receiver and Target allocator - marshaling and unmarshaling of YAML
- https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.118.0/receiver/prometheusreceiver/config.go#L123
- https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.118.0/receiver/prometheusreceiver/targetallocator/config.go#L112
- https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.118.0/receiver/prometheusreceiver/targetallocator/manager.go#L208
- https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.118.0/receiver/prometheusreceiver/targetallocator/manager.go#L246
Ideally this should be carefully considered by the code owners
- S3 provider @Aneurysm9
- ECS observer @dmitryax
- Prometheus receiver @Aneurysm9 @dashpole
Please correct me if I'm missing something and the impact of this change is not as I'm seeing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate from
gopkg.in/yaml.v2togopkg.in/yaml.v3.Some modules were already pulling the two versions and moving to
v3helped removing one of the two for some of them.