Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature command #12014

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
45 changes: 45 additions & 0 deletions otelcol/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
import (
"errors"
"flag"
"fmt"
"os"
"text/tabwriter"

"github.com/spf13/cobra"

Expand Down Expand Up @@ -36,6 +39,7 @@
return col.Run(cmd.Context())
},
}
rootCmd.AddCommand(newFeaturesCommand())
rootCmd.AddCommand(newComponentsCommand(set))
rootCmd.AddCommand(newValidateSubCommand(set, flagSet))
rootCmd.Flags().AddGoFlagSet(flagSet)
Expand Down Expand Up @@ -63,3 +67,44 @@
}
return nil
}

func newFeaturesCommand() *cobra.Command {
return &cobra.Command{
Use: "features [feature-id]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/collector-approvers do you prefer features? gates? featuregates?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

features sounds better to me

Copy link
Member

@TylerHelmuth TylerHelmuth Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote for featuregates or feature-gates since that is the full name of the thing being presented by the command. The term features could apply to something other than feature gates (like the capabilities of the collector).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote for featuregates or feature-gates since that is the full name of the thing being presented by the command. The term features could apply to something than feature gates (like the capabilities of the collector).

should i change the name of command to featuregates then ??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we plan to use features for something else I'm fine with featuregates too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my vote's for featuregates as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my vote's for featuregates as well

Short: "Display feature gates information",
Long: "Display information about available feature gates and their status",
RunE: func(_ *cobra.Command, args []string) error {
if len(args) > 0 {
found := false
featuregate.GlobalRegistry().VisitAll(func(g *featuregate.Gate) {
if g.ID() == args[0] {
found = true
fmt.Printf("Feature: %s\n", g.ID())
fmt.Printf("Enabled: %v\n", g.IsEnabled())
fmt.Printf("Stage: %s\n", g.Stage())
fmt.Printf("Description: %s\n", g.Description())
fmt.Printf("From Version: %s\n", g.FromVersion())
if g.ToVersion() != "" {
fmt.Printf("To Version: %s\n", g.ToVersion())
}

Check warning on line 89 in otelcol/command.go

View check run for this annotation

Codecov / codecov/patch

otelcol/command.go#L77-L89

Added lines #L77 - L89 were not covered by tests
}
})
Comment on lines +79 to +91
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't block this PR, but this feature is a great use case for #7625

if !found {
return fmt.Errorf("feature %q not found", args[0])
}
return nil

Check warning on line 95 in otelcol/command.go

View check run for this annotation

Codecov / codecov/patch

otelcol/command.go#L92-L95

Added lines #L92 - L95 were not covered by tests
}

w := tabwriter.NewWriter(os.Stdout, 0, 0, 2, ' ', 0)
fmt.Fprintf(w, "ID\tEnabled\tStage\tDescription\n")
featuregate.GlobalRegistry().VisitAll(func(g *featuregate.Gate) {
fmt.Fprintf(w, "%s\t%v\t%s\t%s\n",
g.ID(),
g.IsEnabled(),
g.Stage(),
g.Description())
})
return w.Flush()

Check warning on line 107 in otelcol/command.go

View check run for this annotation

Codecov / codecov/patch

otelcol/command.go#L98-L107

Added lines #L98 - L107 were not covered by tests
},
}
}
Loading