Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cargo machete and remove unused dependencies #119

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 18, 2024

Changes

  • removed unused dependencies
  • added cargo machete job to CI to make sure no unused dependencies are left over
  • also updated actions/checkout GHA to the latest version v4

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner October 18, 2024 09:00
Copy link

linux-foundation-easycla bot commented Oct 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cijothomas / name: Cijo Thomas (12b06be)
  • ✅ login: gruebel / name: Anton Grübel (31ec233)

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.6%. Comparing base (56a6f45) to head (12b06be).
Report is 37 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #119     +/-   ##
=======================================
+ Coverage   52.3%   58.6%   +6.3%     
=======================================
  Files         38      39      +1     
  Lines       4967    5774    +807     
=======================================
+ Hits        2598    3387    +789     
- Misses      2369    2387     +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit be31dcb into open-telemetry:main Oct 20, 2024
10 checks passed
@gruebel gruebel deleted the add-machete branch October 20, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants