Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eventheader version for userevents exporter for metrics. #27

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jan 18, 2024

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team January 18, 2024 22:45
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog would nice as well.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14e58a4) 40.4% compared to head (3072a10) 40.4%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #27   +/-   ##
=====================================
  Coverage   40.4%   40.4%           
=====================================
  Files         12      12           
  Lines       1279    1279           
=====================================
  Hits         517     517           
  Misses       762     762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member Author

lalitb commented Jan 18, 2024

@jtescher We need a new package for this crate. It would be unfair to ask you to publish every time. Do you think it would be possible to somehow get the publish access to me and @cijothomas at least for opentelemetry-user-events-metrics and opentelemetry-user-events-logs at this time?

@cijothomas cijothomas merged commit aba3a43 into open-telemetry:main Jan 18, 2024
9 checks passed
@lalitb
Copy link
Member Author

lalitb commented Jan 24, 2024

@jtescher We need a new package for this crate. It would be unfair to ask you to publish every time. Do you think it would be possible to somehow get the publish access to me and @cijothomas at least for opentelemetry-user-events-metrics and opentelemetry-user-events-logs at this time?

@jtescher - Gentle ping on this request :)

@cijothomas
Copy link
Member

@jtescher We need a new package for this crate. It would be unfair to ask you to publish every time. Do you think it would be possible to somehow get the publish access to me and @cijothomas at least for opentelemetry-user-events-metrics and opentelemetry-user-events-logs at this time?

Got the access. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants