Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of Object.keys() #2054

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Replace usages of Object.keys() #2054

wants to merge 4 commits into from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 2, 2025 •
edited
Loading

Fixes #2053.

  1. Converts browser-extension.json to array of objects.
  2. Replaces a Object.keys() usage with a for..in loop.

Before

image

After

image

caugner added 2 commits January 2, 2025 16:30
@caugner
Convert browser extensions data to array
11bedb6 
Avoids `Object.keys()`, not available in Firefox 3.6 and earlier.
@caugner
Replace Object.keys() with for..in loop
7ef2843
caugner
caugner commented Jan 2, 2025
View reviewed changes
browser-extensions.json Outdated Show resolved Hide resolved
queengooborg
queengooborg reviewed Jan 18, 2025
View reviewed changes
browser-extensions.json
Comment on lines +1 to +10
[
{
"name": "NordPass",
"message": "NordPass performs polyfill-like transformations on navigator.credentials, affecting tests for the CredentialsContainer API.",
"affectedTests": ["api.CredentialsContainer"],
"chromeId": "eiaeiblijfjekdanodkjadfinkhbfgcd",
"firefoxId": "0ff38d7a-db91-4a1a-a222-00f10d098b22",
"safariId": "9F9F9D62-DE32-4B4F-88FD-63D448DACFDC"
}
}
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to retain keys in this file because the keys are reported in the test results. Can we revert this and use for key in dict logic instead?

queengooborg
queengooborg requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@queengooborg queengooborg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formal change request, see above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Results don't show in Firefox 3.6 and earlier
2 participants
@caugner @queengooborg