-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: configuration to allow cross-platform
devices for passkeys
#4047
base: master
Are you sure you want to change the base?
Conversation
cross-platform
devices for passkeys
opposite to preserve behavior though
Would it be possible to add an e2e test for this in cypress or playwright? @hperl do passkeys generally support this config value? |
I'm not exactly sure how to write tests in this repo. I checked https://github.com/ory/kratos/pull/3748/files since I should really just be able to copy WebAuthn tests as passkeys only really put it in the device instead of storing it on the server (from what I know). If the tests for passkeys and webauthn don't have anything in relation to the authentication modality, I don't think I could write a test for it. I'm not intimately familiar with the spec so I'm not sure about whether or not I can test it via cypress or playwright. The difference is in what devices are allowed to connect. In the browser |
I‘m not confident that cross-platform is a valid method for „true“ passkeys. @hperl probably knows |
I found this https://passkeys.dev/docs/reference/terms/#cross-device-authentication-cda but yeah I'm not entirely sure either. |
It does indeed look like this is OK: https://passkeys.dev/docs/use-cases/bootstrapping/#cross-device-authentication |
Related issue(s)
#4045
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
This aligns more with expected behavior. If one can sign in using cross platform devices, it doesn't make sense to restrict it to only devices within the same platform.
This is probably considered less secure when compared to the same-device restriction. https://www.passkeys.io allows cross-platform (or at least if this doesn't align it with theirs the behavior is more aligned with this change since I have not read hanko's source code)