Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mapbox-gl-js version to 1.11.0 #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

itbeyond
Copy link

Also updated to support Cordova 9.0.0, Android 8.1.0. iOS 5.1.1

Also updated to support Cordova 9.0.0, Android 8.1.0. iOS 5.1.1
I found a number of updates needed in the worker.js file to bring repo file to latest mapbox.
@alistairfoggin
Copy link

alistairfoggin commented Jun 18, 2020

Having looked at the dependencies, there is still cordova-plugin-compat which is now deprecated as it is included in cordova-android. I believe that this dependency can now be removed along with upgrading the cordova-android and cordova-ios plugins. If there is still a need for it, then it can stay. I just wanted to check the necessity for cordova-plugin-compat before merging. Otherwise, this looks like a great pull request for this repository!

@itbeyond
Copy link
Author

itbeyond commented Jun 18, 2020 via email

@alistairfoggin
Copy link

Having looked closer at the code, there are rollup plugins that are used to transform code as it goes through the build process. These plugins are in build/rollup_plugins.js in the function plugins() on line 19. The replacement of the file will probably need to be before the minifyStyleSpec plugin. There is a plugin called rollup-plugin-re which allows you to replace files. It hasn't had any activity for 2 years but it should still work. The github page is here: https://github.com/jetiny/rollup-plugin-re It has an include option which is the file name that you want to edit (v8.json). Then in the patterns array, you have an object which has a key "file". The value is the path relative to the root of the repository. It will then replace contents of the input file with the contents of your file. At least that is what I understand it to do. I hope this helps. I haven't worked that much with rollup myself.

Also, one minor detail is that the dev dependencies in the package.json seem to be older versions of rollup and the rollup plugins. These may not need to be updated as they are not part of the final build. The official rollup plugins have moved from rollup-plugin-* to @rollup/plugin-* as shown here: https://github.com/rollup/plugins

Hopefully it isn't too difficult to get the style.json to work!

@itbeyond
Copy link
Author

itbeyond commented Jun 19, 2020 via email

@eduboxgithub
Copy link

Thank you so much for your work.

Can this be merged to master ou release as a new version as when fixed?

A small question... With this update can I use Cordova 8.1.2 or I must use version 9 only?

@itbeyond
Copy link
Author

This can be merged and it will work with the sample app without error. As for 8.1.2 I am fairly confident it will work I did push up the version of the sqlite plugin to get past a different error and not sure of it's requrements. The 9.0.0 update is not too bad once you sort out the q = require in your scripts btw.

dansterrett added a commit to canallc/mapbox-gl-cordova-offline that referenced this pull request Jun 6, 2022
… oscarfonts/mapbox-gl-cordova-offline that was never merged (oscarfonts#54).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants