refactor: Adjust KnownProvenance conditional cases

Functions accepting a `KnownProvenance` often only handle the two explicit cases of `Artifact` or `RepositoryProvenance`. Add `else` cases to conditional `when`s. Signed-off-by: Jens Keim <[email protected]>
oss-review-toolkit · Nov 26, 2024 · 7a6f396 · 7a6f396
1 parent 2d70747
commit 7a6f396
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 0 deletions.
diff --git a/model/src/main/kotlin/config/PackageConfiguration.kt b/model/src/main/kotlin/config/PackageConfiguration.kt
@@ -77,6 +77,7 @@ data class PackageConfiguration(
             is UnknownProvenance -> false
             is ArtifactProvenance -> sourceArtifactUrl != null && sourceArtifactUrl == provenance.sourceArtifact.url
             is RepositoryProvenance -> vcs != null && vcs.matches(provenance)
+            else -> false
         }
     }
 }

diff --git a/model/src/main/kotlin/licenses/LicenseInfoResolver.kt b/model/src/main/kotlin/licenses/LicenseInfoResolver.kt
@@ -265,6 +265,7 @@ class LicenseInfoResolver(
             when (provenance) {
                 is UnknownProvenance -> return@forEach
                 is RemoteProvenance -> if (!archiver.unarchive(archiveDir, provenance)) return@forEach
+                else -> return@forEach
             }
 
             val directory = (provenance as? RepositoryProvenance)?.vcsInfo?.path.orEmpty()

diff --git a/model/src/main/kotlin/utils/PurlExtensions.kt b/model/src/main/kotlin/utils/PurlExtensions.kt
@@ -106,6 +106,8 @@ fun Provenance.toPurlExtras(): PurlExtras =
         }
 
         is UnknownProvenance -> PurlExtras()
+
+        else -> PurlExtras()
     }
 
 /**

diff --git a/scanner/src/main/kotlin/provenance/NestedProvenanceResolver.kt b/scanner/src/main/kotlin/provenance/NestedProvenanceResolver.kt
@@ -50,6 +50,7 @@ class DefaultNestedProvenanceResolver(
         return when (provenance) {
             is ArtifactProvenance -> NestedProvenance(root = provenance, subRepositories = emptyMap())
             is RepositoryProvenance -> resolveNestedRepository(provenance)
+            else -> NestedProvenance(root = provenance, subRepositories = emptyMap())
         }
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -106,6 +106,8 @@ fun Provenance.toPurlExtras(): PurlExtras = @@
             }
             is UnknownProvenance -> PurlExtras()
+            else -> PurlExtras()
         }
     /**
@@ Expand Down @@