fix: do not mark github release as latest if higher version exists #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
commented
Mar 15, 2024
| // release exists on GitHub and see if its version is larger | ||
| // than the version we are releasing right now. | ||
| const latestGitHubRelease = await getGitHubRelease('latest') | ||
| const shouldMarkAsLatest = latestGitHubRelease |
kettanaito
commented
Mar 15, 2024
| await cleanup() | ||
| }) | ||
|
|
||
| it('marks the release as non-latest if there is a higher version released on GitHub', async () => { |
There was a problem hiding this comment.
The confirming test suite.
Released: v0.8.1 🎉This has been released in v0.8.1! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using Release for backport releases. It will generate the GitHub release notes as usual for backport releases, which is nice, but won't mark them as
latest.