Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bunfig): add toggle to disable tsconfig features #16825

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link
Contributor

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@robobun
Copy link

robobun commented Jan 28, 2025

Updated 8:46 PM PT - Jan 28th, 2025

@DonIsaac, your commit c57ef78 has 1 failures in Build #10739:


🧪   try this PR locally:

bunx bun-pr 16825

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Jarred-Sumner
Copy link
Collaborator

To serialize IRL discussion:

  • tsconfig.json probably should be overriding package.json "exports" because that's what its meant for - giving people a way to override module resolution (curious if @andrewbranch has an opinion)
  • The motivating usecase, Playwright's repo with a build step that relies on tsconfig.json paths at build-time and not being evaluated at runtime, is something we can support through the node shim we automatically use in bun --bun and through a bunfig.toml option to disable reading tsconfig.json

@DonIsaac DonIsaac force-pushed the don/fix/exports-tsconfig-paths-conflict branch 3 times, most recently from e066cc8 to ca70dab Compare January 28, 2025 20:49
@DonIsaac DonIsaac changed the title fix(resolve): exports field should take precedence over tsconfig paths feat(bunfig): add toggle to disable tsconfig features Jan 28, 2025
@DonIsaac DonIsaac force-pushed the don/fix/exports-tsconfig-paths-conflict branch from caf77df to c57ef78 Compare January 29, 2025 03:37
@andrewbranch
Copy link

tsconfig.json paths does indeed take precedence over everything else in TypeScript’s resolution, if that’s what you’re asking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants