allow resolution to work when the source file does not exist

[paperclover]

Fixes #16705

URL decoding issues

Vite handles percent encoding special characters like / and : in urls, but expects pathToFileURL to encode %2F as %252F (encoding the %). This change has been made in WebKit since i believe all places we create file URLs out of paths should have this, for example import.meta.url in a file named %2F.js (which also matches node)

Resolver changes

Nuxt/Vite uses createRequire("file://...") to facilitate require in files. Some virtual files get a filepath @vue/server-renderer which gets normalized to an absolute path relative to the current working directory (file:///Users/clo/scratch/my-nuxt-app/@vue/server-renderer). This path, given to createRequire, produces a function that cant resolve from node_modules in Bun, but can in Node.js. The bug in Bun is when we walk up for node_modules, we use a directory cache; but the cache is not populated for non-existing directories. The change is to walk up until a cache entry exists, then to use it.

This can be reproduced in the node and bun repls, by replacing the path to your project dir.

require("module").createRequire("file:///Users/clo/scratch/my-nuxt-app/@vue/server-renderer")("vue")

Here is the code path in Node.js that causes this to successfully resolve

• createRequire calls createRequireFromPath and assigns m.paths to the list of all parent paths that contain a node_modules link
• require calls _resolveFilename with the parent module (above: m) and the request
• since it does not call it with any options, this line paths = Module._resolveLookupPaths(request, parent);
• the paths value becomes the concatenation of m.paths above (in code parent.paths) and the list of NODE_PATH entries. [link](https://github.com/nodejs/node/blob/e346323109b49fa6b9a4705f4e3816fc3a30c151/lib/internal/modules/cjs/loader.js#L930. this is hit since the require string "vue" is not a relative file path
• trySelf does some native code and finds zero results. this is the directory traversal i mentioned before, which would find the nearest package.json, the import is not a self referential import.
• _findPath loops through paths from point 4
• the module is resolved

[robobun]

^{Updated 2:52 AM PT - Jan 30th, 2025}

❌ @Jarred-Sumner, your commit 9cf9e00 has 2 failures in Build #10834:

• test/js/bun/util/filesink.test.ts - timeout on 🪟 2019 x64-baseline
• test/js/bun/util/filesink.test.ts - timeout on 🪟 2019 x64
• test/js/web/websocket/autobahn.test.ts - code 1 on 🐧 20.04 x64-baseline

---

🧪   try this PR locally:

bunx bun-pr 16851

[paperclover]

my worry on this loop is that dirInfoCached does not seem to cache not found entries, which might be worth doing in some places. on the other hand, that type of caching can lead to problems.

[Jarred-Sumner]

It does cache not found entries. No need to worry.