Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle __esModule for loader: "object" #16885

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Correctly handle __esModule for loader: "object"

Unlike CJS normally, we were ignoring the __esModule property.

How did you verify your code works?

There is a test that fails in previous versions of Bun and passes in this version

@robobun
Copy link

robobun commented Jan 29, 2025

Updated 6:03 AM PT - Jan 31st, 2025

@Jarred-Sumner, your commit 14e9bf6 has 3 failures in Build #10921:


🧪   try this PR locally:

bunx bun-pr 16885

@Jarred-Sumner Jarred-Sumner merged commit 9acb72d into main Jan 31, 2025
7 of 33 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/object-module__esModule branch January 31, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants