Implement PNG optimizer with pillow #2068
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all Image optmizers will fork/exec on an external program for every single image tile generated from dispatcher. This drags the performance in the optimizing phase due to expensive user/kernel space switching. Using PIL/pillow allows image operations without launching external programs. Hopefully this is an acceptable tradeoff between performance and resulting file size.
For some reason PIL is not part of requirements.txt, but seems to be assumed to exist in other parts of Overviewer. Programmatically imported modules cannot be pickled and thus fails under multiprocessing, so we are taking the assumption and import PIL early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all Image optmizers will fork/exec on an external program for every single image tile generated from dispatcher. This drags the performance in the optimizing phase due to expensive user/kernel space switching during process spawning.
Using PIL/pillow allows image operations without launching external programs. Hopefully this is an acceptable tradeoff between performance and resulting file size.