Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine): emit events with executed blocks #14341

Merged
merged 2 commits into from
Feb 9, 2025
Merged

feat(engine): emit events with executed blocks #14341

merged 2 commits into from
Feb 9, 2025

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Feb 9, 2025 •
edited
Loading

Description

Emit executed block with trie updates, so that the event subscriber can deal with full block data. Ref #14268

@rkrasiuk rkrasiuk added S-blocked This cannot more forward until something else changes A-engine Related to the engine implementation labels Feb 9, 2025
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/emit-pending-blocks branch 2 times, most recently from bcada58 to c58c557 Compare February 9, 2025 08:52
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/emit-pending-blocks branch from c58c557 to 98b582a Compare February 9, 2025 10:41
@rkrasiuk rkrasiuk added C-enhancement New feature or request and removed S-blocked This cannot more forward until something else changes labels Feb 9, 2025
@rkrasiuk rkrasiuk marked this pull request as ready for review February 9, 2025 10:42
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/emit-pending-blocks branch from 98b582a to 5e69f9b Compare February 9, 2025 10:44
mattsse
mattsse approved these changes Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, this now also saves some clones

@rkrasiuk rkrasiuk added this pull request to the merge queue Feb 9, 2025
Merged via the queue into main with commit a215256 Feb 9, 2025
44 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/emit-pending-blocks branch February 9, 2025 11:29
18aaddy pushed a commit to 18aaddy/reth that referenced this pull request Feb 12, 2025
@rkrasiuk @18aaddy
feat(engine): emit events with executed blocks (paradigmxyz#14341)
29cf32d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-engine Related to the engine implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse