Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add msrv check job #1522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+23 −0
Open

ci: add msrv check job #1522

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c84726f
ci: add msrv check job
king-11 Jan 24, 2025
c49c18e
Update .github/workflows/ci.yml
niklasad1 Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,29 @@ jobs:
- name: Check unused dependencies
run: cargo machete

check-msrv:
name: Check
niklasad1 marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
steps:

- uses: actions/[email protected]

- name: Install Rust 1.74.0 toolchain
uses: actions-rs/[email protected]
with:
profile: minimal
toolchain: 1.74.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this at first so maybe just to make it obvious:

Suggested change
toolchain: 1.74.0
# Check that tests pass using our MSRV:
toolchain: 1.74.0

override: true

- name: Rust Cache
uses: Swatinem/[email protected]

- name: Cargo test
uses: actions-rs/[email protected]
with:
command: test
args: --workspace

tests_ubuntu:
name: Run tests Ubuntu
runs-on: ubuntu-latest
Expand Down
Loading