Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track names #202

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Track names #202

wants to merge 2 commits into from

Conversation

algesten
Copy link

Hi!

I've been testing out using the Demuxer directly using symphonia-core and symphonia-format-mkv. I'm quite used to dealing with demuxers and codecs, and using them works great!

For my use case, I'm decoding MKV- and MP4-files that have both audio and video, but I'm only interesting in extracting the audio. The containers also have multiple audio files, and they are differentiated by name. However the names are not currently surfaced in Track.

Reading the crates.io README for core and format-mkv, I see:

Note: This crate should only be used if developing Project Symphonia decoders and demuxers. For other use cases please use the symphonia crate.

I've been trying to read other PRs and Issues to understand what the stance is on using the lower level crates. Is it a supported use case or not? I totally get that it might not be.

As for the track names. Would you be open to a PR that starts doing that for MKV and MP4? You can see the start of my changes here.

This allows the various demuxers to constructs the parts of Track they support.
This adds Track::name as an Optional<String>. This in turn is used by
MKV demuxer to surface the track name.
@dedobbin
Copy link
Contributor

dedobbin commented Sep 4, 2023

I understand the need and it seems definitely valid, but i think it would be a better fit for metadata?
It would involve mapping the metadata to individual tracks though, which would probably broaden the scope of the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants