-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API method-specific extension functions #412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds to SuccessfulPayment
…otlin Data Classes
…dInlineMessage & SendGift
…essage, SetUserEmojiStatus
… customParameterName parameter usage
25ade71
to
c9c33c1
Compare
pengrad
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Seems enough to merge only this one as it contains both v8 and v8.1
This was referenced Jan 26, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds method-specific functions. (originally from sktb-spring-boot-starter)
It's my vision of a Kotlin-way API usage.
It based on #409 and #408 and there are only two diffs: 5a994fa, 25ade71
It looks similar to #331, but without breaking changes and moving client-specific logic to request classes
Added:
TelegramAware interface
All extensions are made for this interface.
Use case:
sktb-spring-boot-starter has a TelegramBot wrapper – TelegramService.kt
This interface allows to implement it and use all extensions even in wrapper.
Extension for API methods (what I use most often in my projects, todo: add extensions for every method in furture releases)
Example:
You can use:
or general
execute
function for not-implemented API methods:instead of more complex or Java-style usages:
With the Request Property Delegates (Bot API v8.0 #408), it will allow to build requests by setting properties, for example:
RequestPreprocessor interface
A functional interface. It should be called before any request execution.
By default, it does nothing, but it can be used to modify request before execution.
Use case:
sktb-spring-boot-starter has a FormatUtility with default formatting options – FormatUtility.kt
This formatting settings are applied in extension functions by default in TelegramAwareExtension.kt
RequestPreprocessor makes possible to apply sktb-default formatting options and still use buildin extensions