Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket drop time UI support, unapproved club event visibility changes #750

Merged
merged 13 commits into from
Feb 6, 2025

Conversation

julianweng
Copy link
Member

@julianweng julianweng commented Nov 23, 2024

  • Add UI support for ticket drop times
  • Add ticket_drop_time validation in event serializer based on event end time
  • Prevent retroactive editing of ticket drop time after tickets have been sold (plus handling of edge case where ticket has been added to cart but not bought before ticket drop time is pushed back)
  • Prevent unapproved clubs from selling tickets (add_to_cart)
  • Prevent clubs which have been archived from selling existing tickets
  • Allow leaders of unapproved clubs to create and view events (with the warning that such events are not visible to the public until the club is approved), allowing for "draft" functionality (also currently, the event just disappears after submission on the frontend for unapproved clubs...)
  • Standardize spelling of "publicly" in the codebase (alternative being "publically")
  • Add button to view public event page within event editing page
  • Show all clubs in /directory which have been approved at some point

Event page with unreleased tickets

Unapproved club event (displayed to officers only)

Note for events without a ticket_drop_time

User viewport after clicking on link to ticket_drop_time field within note

…ing details for non-dropped events, add ticket_drop_time serializer validation, make events belonging to unapproved clubs visible to club leaders specifically, standardize spelling of "publicly"
…ged following a ticket being added to a user's cart
@julianweng julianweng linked an issue Nov 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.99%. Comparing base (b280dc0) to head (a531327).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
backend/clubs/views.py 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   71.95%   71.99%   +0.04%     
==========================================
  Files          32       32              
  Lines        6953     6967      +14     
==========================================
+ Hits         5003     5016      +13     
- Misses       1950     1951       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aviupadhyayula aviupadhyayula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up (and sorry for getting to this so late). Left some comments on the backend changes. Frontend changes LGTM!

backend/clubs/serializers.py Outdated Show resolved Hide resolved
backend/clubs/views.py Show resolved Hide resolved
backend/clubs/views.py Outdated Show resolved Hide resolved
backend/clubs/views.py Show resolved Hide resolved
backend/clubs/views.py Outdated Show resolved Hide resolved
@julianweng julianweng force-pushed the 698-support-ticket-drop-times-on-frontend branch from af5e57c to 8d0adca Compare January 30, 2025 04:29
@julianweng julianweng self-assigned this Feb 5, 2025
@julianweng julianweng requested review from aviupadhyayula and removed request for rm03 February 5, 2025 14:18
Copy link
Member

@aviupadhyayula aviupadhyayula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Julian! Left some comments, thanks for picking this PR back up.

backend/clubs/serializers.py Show resolved Hide resolved
backend/clubs/views.py Outdated Show resolved Hide resolved
backend/clubs/views.py Outdated Show resolved Hide resolved
backend/tests/clubs/test_ticketing.py Show resolved Hide resolved
Copy link
Member

@aviupadhyayula aviupadhyayula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend LGTM! If you feel good about the frontend feel free to merge.

@julianweng julianweng merged commit 830bd50 into master Feb 6, 2025
8 checks passed
@julianweng julianweng deleted the 698-support-ticket-drop-times-on-frontend branch February 6, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ticket drop times on frontend
2 participants