Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert run-script-on-filetype-change to new Webpack 4 plugin api. #308

Merged
merged 8 commits into from
Jun 18, 2018

Conversation

illepic
Copy link
Contributor

@illepic illepic commented Jun 9, 2018

Work in progress. No need to review yet.

Changes

  • Moving our initial PL compile to webpack.pl.shared.js via simple spawnSync() scripts
  • As such, removing:
    • dev:pl:webpack
    • dev:pl:gulp
    • dev:drupal:webpack
    • dev:drupal:gulp
    • dev:grav:webpack
    • dev:grav:gulp
  • Any gulp tasks can be run directly via npx gulp task-name.
  • run-script-on-filetype-change has been updated to Webpack 4 API.
  • No longer generating source/_data/env.json on every PL compile, thus reducing Webpack emits and unnecessary writes to within source/.
  • Wrote our own RunScriptAfterEmit so there is no longer a dependency on WebpackShellPlugin (which is not Webpack 4 compatible)

@illepic illepic self-assigned this Jun 9, 2018
@illepic illepic requested a review from a team June 9, 2018 17:17
@illepic illepic changed the title [WIP] Convert run-script-on-filetype-change to new Webpack 4 plugin api. Convert run-script-on-filetype-change to new Webpack 4 plugin api. Jun 17, 2018
@entorenee entorenee self-requested a review June 18, 2018 16:29
@illepic
Copy link
Contributor Author

illepic commented Jun 18, 2018

Noting that we need some big updates to the official docs. Leaning heavily on npx now to run gulp tasks.

@illepic illepic merged commit 3c19bba into master Jun 18, 2018
@illepic illepic deleted the feature/custom-webpack-plugin-update branch June 18, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants