Remove MCLONE system call (#118)

Remove unused MCLONE system call.

This system call used to be used by the userspace loader but isn't
anymore.

doc/syscalls/README.md

@@ -21,7 +21,7 @@
 | 12      | [EXIT_THREAD](exit-thread.md)           | Terminate the current thread         |
 | 13      | [MMAP](mmap.md)                         | Map memory                           |
 | 14      | [CREATE_PROCESS](create-process.md)     | Create a process                     |
-| 15      | [MCLONE](mclone.md)                     | Clone a memory mapping               |
+| 15      | -                                       | Reserved                             |
 | 16      | [DUP](dup.md)                           | Duplicate a descriptor               |
 | 17      | [CLOSE](close.md)                       | Close a descriptor                   |
 | 18      | [DESTROY](destroy.md)                   | Destroy a kernel object              |
@@ -30,7 +30,7 @@
 | 21      | [AWAIT_THREAD](await-thread.md)         | Wait for a thread to exit            |
 | 22      | [REPLY_ERROR](reply-error.md)           | Reply to message with an error       |
 | 23-4095 | -                                       | Reserved                             |
-| 4096+   | [SEND](send.md)                         | Send a message                         |
+| 4096+   | [SEND](send.md)                         | Send a message                       |
 
 #### Reserved Function Numbers
 

include/jinue/jinue.h

@@ -90,15 +90,6 @@ int jinue_create_endpoint(int fd, int *perrno);
 
 int jinue_create_process(int fd, int *perrno);
 
-int jinue_mclone(
-        int      src,
-        int      dest,
-        void    *src_addr,
-        void    *dest_addr,
-        size_t   length,
-        int      prot,
-        int     *perrno);
-
 int jinue_dup(int process, int src, int dest, int *perrno);
 
 int jinue_close(int fd, int *perrno);

include/jinue/shared/asm/syscalls.h

@@ -68,9 +68,6 @@
 /** create a new process */
 #define JINUE_SYS_CREATE_PROCESS        14
 
-/** clone a memory mapping from the current process to another */
-#define JINUE_SYS_MCLONE                15
-
 /** duplicate a descriptor from the current process to another */
 #define JINUE_SYS_DUP                   16
 

include/jinue/shared/types.h

@@ -99,13 +99,6 @@ typedef struct {
     uint64_t     paddr;
 } jinue_mmap_args_t;
 
-typedef struct {
-    void        *src_addr;
-    void        *dest_addr;
-    size_t       length;
-    int          prot;
-} jinue_mclone_args_t;
-
 typedef struct {
     int         process;
     int         fd;

include/kernel/application/syscalls.h

@@ -54,8 +54,6 @@ void *get_thread_local(void);
 
 int get_address_map(const jinue_buffer_t *buffer);
 
-int mclone(int src, int dest, const jinue_mclone_args_t *args);
-
 int mint(int owner, const jinue_mint_args_t *args);
 
 int mmap(int process_fd, const jinue_mmap_args_t *args);

kernel/Makefile

@@ -74,7 +74,6 @@ sources.kernel.c = \
 	application/syscalls/await_thread.c \
 	application/syscalls/mint.c \
 	application/syscalls/mmap.c \
-	application/syscalls/mclone.c \
 	application/syscalls/puts.c \
 	application/syscalls/reboot.c \
 	application/syscalls/receive.c \

kernel/interface/syscalls.c

@@ -375,59 +375,6 @@ static void sys_create_process(jinue_syscall_args_t *args) {
     set_return_value_or_error(args, retval);
 }
 
-static void sys_mclone(jinue_syscall_args_t *args) {
-    const jinue_mclone_args_t *userspace_mclone_args;
-
-    int src                 = get_descriptor(args->arg1);
-    int dest                = get_descriptor(args->arg2);
-    userspace_mclone_args   = (void *)args->arg3;
-
-    if(src < 0) {
-        set_return_value_or_error(args, src);
-        return;
-    }
-
-    if(dest < 0) {
-        set_return_value_or_error(args, dest);
-        return;
-    }
-
-    if(! check_userspace_buffer(userspace_mclone_args, sizeof(jinue_mclone_args_t))) {
-        set_error(args, JINUE_EINVAL);
-        return;
-    }
-
-    jinue_mclone_args_t mclone_args = *userspace_mclone_args;
-
-    if(OFFSET_OF_PTR(mclone_args.src_addr, PAGE_SIZE) != 0) {
-        set_error(args, JINUE_EINVAL);
-        return;
-    }
-
-    if(OFFSET_OF_PTR(mclone_args.dest_addr, PAGE_SIZE) != 0) {
-        set_error(args, JINUE_EINVAL);
-        return;
-    }
-
-    if((mclone_args.length & (PAGE_SIZE -1)) != 0) {
-        set_error(args, JINUE_EINVAL);
-        return;
-    }
-
-    if((mclone_args.prot & ~ALL_PROT_FLAGS) != 0) {
-        set_error(args, JINUE_EINVAL);
-        return;
-    }
-
-    if((mclone_args.prot & WRITE_EXEC) == WRITE_EXEC) {
-        set_error(args, JINUE_ENOTSUP);
-        return;
-    }
-
-    int retval = mclone(src, dest, &mclone_args);
-    set_return_value_or_error(args, retval);
-}
-
 static void sys_dup(jinue_syscall_args_t *args) {
     int process_fd  = get_descriptor(args->arg1);
     int src         = get_descriptor(args->arg2);
@@ -607,9 +554,6 @@ void handle_syscall(jinue_syscall_args_t *args) {
         case JINUE_SYS_CREATE_PROCESS:
             sys_create_process(args);
             break;
-        case JINUE_SYS_MCLONE:
-            sys_mclone(args);
-            break;
         case JINUE_SYS_DUP:
             sys_dup(args);
             break;

userspace/lib/jinue/syscalls.c

@@ -222,31 +222,6 @@ int jinue_create_process(int fd, int *perrno) {
     return call_with_usual_convention(&args, perrno);
 }
 
-int jinue_mclone(
-        int      src,
-        int      dest,
-        void    *src_addr,
-        void    *dest_addr,
-        size_t   length,
-        int      prot,
-        int     *perrno) {
-
-    jinue_syscall_args_t args;
-    jinue_mclone_args_t mclone_args;
-
-    mclone_args.src_addr = src_addr;
-    mclone_args.dest_addr = dest_addr;
-    mclone_args.length = length;
-    mclone_args.prot = prot;
-
-    args.arg0 = JINUE_SYS_MCLONE;
-    args.arg1 = src;
-    args.arg2 = dest;
-    args.arg3 = (uintptr_t)&mclone_args;
-
-    return call_with_usual_convention(&args, perrno);
-}
-
 int jinue_dup(int process, int src, int dest, int *perrno) {
     jinue_syscall_args_t args;