Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ZEND_FCI_INITIALIZED() macro to check if an FCI is initialized #17291

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Use ZEND_FCI_INITIALIZED() macro to check if an FCI is initialized #17291

merged 1 commit into from
Jan 31, 2025
+1 −1

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Dec 29, 2024

It feels like the PDO checks were wrong and those might need to be backported.

@Girgias Girgias marked this pull request as ready for review December 29, 2024 03:49
dstogov
dstogov approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see problems, except of merge conflict.

@Girgias Girgias force-pushed the fci-initialized-macro branch from b52a903 to ce851cc Compare January 31, 2025 12:10
@Girgias Girgias merged commit b4f275f into php:master Jan 31, 2025
8 of 9 checks passed
@Girgias Girgias deleted the fci-initialized-macro branch January 31, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi

Assignees
No one assigned
Labels
Category: Engine Extension: pdo (core)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @dstogov