I18N-1323 Update Mojito CLI to use OpenAPI spec for rest calls #201
Conversation
| @@ -173,7 +173,8 @@ public SecurityFilterChain configure(HttpSecurity http) throws Exception { | |||
| "/cli/**", | |||
| "/js/**", | |||
| "/css/**", | |||
| "/error") | |||
| "/error", | |||
| "/v3/api-docs") | |||
There was a problem hiding this comment.
This endpoint should be open for open api file generation during the integration test phase
| <goal>generate</goal> | ||
| </goals> | ||
| <configuration> | ||
| <inputSpec>${project.parent.basedir}/webapp/src/main/resources/openapi.json</inputSpec> |
There was a problem hiding this comment.
It points to the file generated in the webapp module
DarKhaos
force-pushed
the
I18N-1323
branch
3 times, most recently
from
20c063b to
e3582e7
Compare
cli/src/main/java/com/box/l10n/mojito/cli/apiclient/AuthenticatedApiClient.java
Outdated
Show resolved
Hide resolved
| Request request = new Request.Builder().url(url).build(); | ||
| this.latestCsrfToken = this.getCsrfToken(httpClient, request); | ||
| RequestBody requestBody = | ||
| new FormEncodingBuilder().add("username", "admin").add("password", "ChangeMe").build(); |
There was a problem hiding this comment.
We shouldn't be hardcoding usernames and passwords like this? Why is this interceptor required?
There was a problem hiding this comment.
An interceptor is required to authenticate requests
startAuthenticationFlow
There was a problem hiding this comment.
We can't hard-code the passwords as done here, I'm assuming this is just done as this is a work in progress? The CredentialProvider should be reused here as in the flow you've linked to
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| @Configuration | ||
| public class WsApiConfig { |
There was a problem hiding this comment.
Why are these new Beans required? Why can't we use the existing *WS.java class endpoints?
cli/src/main/java/com/box/l10n/mojito/cli/apiclient/RepositoryWsApiHelper.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/service/scheduledjob/ScheduledJobTypeRepository.java
Outdated
Show resolved
Hide resolved
DarKhaos
force-pushed
the
I18N-1323
branch
23 times, most recently
from
69cdca6 to
6bf7cfb
Compare
Auto-generated code for rest calls
Changed swagger-codegen-maven plugin configuration
Modified dependencies
Modified open API config
Refactor rest client
Refactored user rest calls
Fixed pagination issue
Updated package of the generated code
Refactored some commands
Refactored commit commands
Fixed custom model resolver
Refactored Branch commands
Refactored AI Prompt commands
Refactor AI commands
Addressed PR comments
Refactor commands
Fixed schemas' issues
DarKhaos
force-pushed
the
I18N-1323
branch
5 times, most recently
from
e36bc11 to
a4da5f8
Compare
| server.servlet.session.cookie.name=JSESSIONID | ||
|
|
||
| l10n.ai.enabled=true |
There was a problem hiding this comment.
Needed to generate classes for AI endpoints
DarKhaos
force-pushed
the
I18N-1323
branch
4 times, most recently
from
46b17d4 to
e36219a
Compare
Refactor other commands
Generate code from open API specification and reuse the generated models and clients