Fix config typo causing restart range to be no-op (#6)

Change config check to verify if endTime is strictly larger than startTime
pinterest · Sep 5, 2019 · 8adc8cf · 8adc8cf
1 parent 2ee93bc
commit 8adc8cf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/singer/src/main/java/com/pinterest/singer/common/SingerConfigDef.java b/singer/src/main/java/com/pinterest/singer/common/SingerConfigDef.java
@@ -29,7 +29,7 @@ public class SingerConfigDef {
   public static final String DAILY_RESTART_FLAG = "daily";
   public static final String NUMBER_OF_FAILURES_ALLOWED = "numberOfFailuresAllowed";
   public static final String DAILY_RESTART_TIME_BEGIN = "dailyRestartUtcTimeRangeBegin";
-  public static final String DAILY_RESTART_TIME_END = "dailyRestartUtcTimeRangeBegin";
+  public static final String DAILY_RESTART_TIME_END = "dailyRestartUtcTimeRangeEnd";
 
   public static final String MONITOR_INTERVAL_IN_SECS = "monitorIntervalInSecs";
 

diff --git a/singer/src/main/java/com/pinterest/singer/utils/LogConfigUtils.java b/singer/src/main/java/com/pinterest/singer/utils/LogConfigUtils.java
@@ -268,8 +268,8 @@ private static SingerRestartConfig parseSingerRestartConfig(PropertiesConfigurat
           .getString(SingerConfigDef.DAILY_RESTART_TIME_END);
       Date startTime = SingerUtils.convertToDate(restartConfig.dailyRestartUtcTimeRangeBegin);
       Date endTime = SingerUtils.convertToDate(restartConfig.dailyRestartUtcTimeRangeEnd);
-      if (endTime.compareTo(startTime) < 0) {
-        throw new ConfigurationException("Daily restart end time is earlier than start time");
+      if (endTime.compareTo(startTime) <= 0) {
+        throw new ConfigurationException("Daily restart end time is not later than start time");
       }
     }
     return restartConfig;