Add plonecli/bobtemplates.plone compatible markers and configuration #63
Conversation
...rc/{{ cookiecutter.__package_namespace }}/{{ cookiecutter.__package_name }}/permissions.zcml
Outdated
Show resolved
Hide resolved
...r.__package_namespace }}/{{ cookiecutter.__package_name }}/profiles/default/controlpanel.xml
Outdated
Show resolved
Hide resolved
...ecutter.__package_namespace }}/{{ cookiecutter.__package_name }}/vocabularies/configure.zcml
Outdated
Show resolved
Hide resolved
Thanks for your review!!! |
| version = 6.0.13 | ||
| template = plone_addon | ||
| git_init = True | ||
| python = python3 |
There was a problem hiding this comment.
This is not necessarily a blocker, but would it be possible to add support for mr.bob/bobtemplates.plone to get their settings from pyproject.toml, so that we don't need more config files?
There was a problem hiding this comment.
I guess that there's no problem with that. Would you mind adding an issue in bobtemplates.plone repo?
|
@davisagli I have rephrased the existing example, added a couple more and linked the README file where all subtemplates are listed. |
| This package provides markers as strings (`<!-- extra stuff goes here -->`) that are compatible with [`plonecli`](https://github.com/plone/plonecli) and [`bobtemplates.plone`](https://github.com/plone/bobtemplates.plone). | ||
| These markers act as hooks to add all kinds of subtemplates, including behaviors, control panels, upgrade steps, or other subtemplates from `plonecli`. | ||
|
|
||
| To use them, you need to use `bobtemplates.plone` version X.X.X or later, and run the following command. |
There was a problem hiding this comment.
We need to update the version number here. The current version of bobtemplates.plone is 6.3.3. Is this feature already in a release or a future one?
There was a problem hiding this comment.
No yet, there's a pending PR on bobtemplates.plone to be able to use these changes.
There was a problem hiding this comment.
The PR was merged early this week, but the release is still missing.
* Add more references. See plone/cookieplone-templates#63 * Incorporate @erral's suggestions, I think
|
Would it be useful to add a |
maybe calling mr.bob directly is a better idea, but both work. The only thing is, plonecli is already a wrapper around bobtemplates.plone, so for a Makefile i would do the same as plonecli does, but call the templates directly. |
The point was trying to use the same mechanism that this template provides: use But I am open to discuss it :) |
…tter.__package_namespace }}/{{ cookiecutter.__package_name }}/permissions.zcml
Co-authored-by: Steve Piercy <[email protected]>
…tter.__package_namespace }}/{{ cookiecutter.__package_name }}/profiles/default/controlpanel.xml
Co-authored-by: Steve Piercy <[email protected]>
…tter.__package_namespace }}/{{ cookiecutter.__package_name }}/vocabularies/configure.zcml
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
erral
force-pushed
the
erral-allow-using-plonecli
branch
from
949dbb0
to
daf03c0
Compare
Adding these markers, one can use
ploneclito add features to the backend addon.This needs plone/bobtemplates.plone#568 to correctly work.
And also some documentation that I will be adding in the backend package's README file, because it needs to run
plonecliwith the custom configuration file provided here.I think that plonecli/bobtemplates.plone is mature enough and saves a lot of time when adding features to backend, and it will be definelty useful in a project/add-on generator like this.