feat: Implement Co-badged Cards on Drop-in #1050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Debug App/Sources/View Controllers/MerchantHeadlessCheckoutRawDataViewController.swift
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| guard let self = self else { return } | ||
| self.alternativelySelectedCardNetwork = cardNetwork.network | ||
| self.rawCardData.cardNetwork = cardNetwork.network | ||
| self.rawDataManager?.rawData = self.rawCardData // TODO: (BNI) This does not work for unknown reason |
There was a problem hiding this comment.
⚠️ TODOs should be resolved ((BNI) This does not work for u...). (todo)
Generated by 🚫 Danger Swift against ba30089 |
borisprimer
force-pushed
the
feature/ACC-4371-co-badged-on-dropin
branch
from
e9821b2 to
ceca053
Compare
borisprimer
force-pushed
the
feature/ACC-4371-co-badged-on-dropin
branch
from
4110a2a to
893634f
Compare
|
Appetize link: https://appetize.io/app/ju633gutygpu3uqvzhjm2eeehq |
….com/primer-io/primer-sdk-ios into feature/ACC-4371-co-badged-on-dropin
borisprimer
force-pushed
the
feature/ACC-4371-co-badged-on-dropin
branch
from
050b0de to
5a157b4
Compare
|
borisprimer
force-pushed
the
feature/ACC-4371-co-badged-on-dropin
branch
from
e88f4c1 to
bb4db87
Compare
borisprimer
force-pushed
the
feature/ACC-4371-co-badged-on-dropin
branch
from
bb4db87 to
ec8d36c
Compare
NQuinn27
previously approved these changes
Jan 22, 2025
|
@borisprimer looks like we have a failing UI test since adding these changes |
| } | ||
| // swiftlint:enable type_body_length |
There was a problem hiding this comment.
⚠️ File should contain 400 lines or less: currently contains 401 (file_length)
borisprimer
force-pushed
the
feature/ACC-4371-co-badged-on-dropin
branch
from
912596c to
ba30089
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CHKT-4371
Other Notes
Manual Testing
I tested manually multiple scenarios, it would be nice to test it as well if you can @NQuinn27