feat!: change to ESM #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angeloashmore
force-pushed
the
aa/fix-usage-obelix
branch
from
09fa7b4 to
10fb86b
Compare
size-limit report 📦
|
4 tasks
angeloashmore
changed the title
change-case dependency
xrutayisire
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #28
Description
This PR marks
@prismicio/mockas an ES Module via"type": "module".See the motivation behind the change in #28.
change-caseremovalThis PR replaces the
change-casedependency with a simplified internal version.@prismicio/mocknow has no dependencies (however, it retains the@prismicio/clientpeer dependency).This change was motivated by #28, in which
@prismicio/mockneeded"type": "module"for Playwright compatibility. To avoid weird ESM juggling between dependencies, we can remove the only dependency:change-case.All mock output should be practically identical from before. There may be slight differences in edge cases, but the output should be 100% compatible.
Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩