Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type link variants #67

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: type link variants #67

wants to merge 3 commits into from

Conversation

lihbr
Copy link
Member

@lihbr lihbr commented Jan 16, 2025

Resolves:

Description

Add missing types for link variants.

Checklist

  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

image

How to QA 1

  • Checkout branch, install, and build
  • npm link
  • In a Slice Machine project: npm update @prismicio/client && npm link prismic-ts-codegen
  • Add a link field with variants
  • Check types

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants