Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE-2024-45338 - update golang.org/x/net #646

Merged

Conversation

varshaprasad96
Copy link
Contributor

Issue link

Fix CVE: https://issues.redhat.com/browse/RHOAIENG-17191

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@varshaprasad96
Copy link
Contributor Author

@ChristianZaccaria Here we go! Could you please approve. Thank you!

Copy link
Contributor

@Ygnas Ygnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, CVE is fixed with the changes

@openshift-ci openshift-ci bot added the lgtm label Jan 6, 2025
@Ygnas
Copy link
Contributor

Ygnas commented Jan 6, 2025

Just a question do we need really need commit as [CARRY] here?

@varshaprasad96 varshaprasad96 changed the title [CARRY]: Fix CVE-2024-45338 - update golang.org/x/net Fix CVE-2024-45338 - update golang.org/x/net Jan 6, 2025
@varshaprasad96
Copy link
Contributor Author

@Ygnas actually we don't. I had cherry-picked the commit from one of the downstream branches, so it ended up having the same message.

Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Nice one!
/lgtm

Copy link

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChristianZaccaria, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 5e354dc into project-codeflare:main Jan 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants