-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CVE-2024-45338 - update golang.org/x/net #646
Fix CVE-2024-45338 - update golang.org/x/net #646
Conversation
@ChristianZaccaria Here we go! Could you please approve. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it, CVE is fixed with the changes
Just a question do we need really need commit as [CARRY] here? |
@Ygnas actually we don't. I had cherry-picked the commit from one of the downstream branches, so it ended up having the same message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Nice one!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChristianZaccaria, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5e354dc
into
project-codeflare:main
Issue link
Fix CVE: https://issues.redhat.com/browse/RHOAIENG-17191
What changes have been made
Verification steps
Checks