Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permits ERB syntax in downloads.yml file #1564

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sjproctor
Copy link

This commit fixes the malformed format string - %= error that occurs when ERB syntax is used in the downloads.yml file.

Screenshot 2024-11-07 at 4 40 09 PM

This commit fixes the `malformed format string - %=` error that occurs
when ERB syntax is used in the `downloads.yml` file.
@corylown
Copy link
Contributor

corylown commented Nov 8, 2024

Hi @sjproctor -- can you say a bit more about why this change is needed? The current downloads.yml pattern is to use %{} syntax that will evaluate accessor methods set on SolrDocument. What's the use case that this pattern doesn't cover?

@sjproctor
Copy link
Author

Hi @sjproctor -- can you say a bit more about why this change is needed? The current downloads.yml pattern is to use %{} syntax that will evaluate accessor methods set on SolrDocument. What's the use case that this pattern doesn't cover?

Hi there. I am looking to use an environment variable in the yml file. The ERB tags are causing an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants