Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message when manylinux-interpreters ensure ... failed #2066

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Nov 2, 2024

As reported in #2062 (comment), the error message needs to be fixed.
The failure can also be seen in another build on Travis CI: https://app.travis-ci.com/github/pypa/cibuildwheel/jobs/627703558?serverType=git

2 options proposed:

  • If interpreter presence check fails, check the result of manylinux-interpreters ensure ... to decide on the error message to present to the user.
  • Don't run the presence check when manylinux-interpreters is available and rely only on it to pass or fail properly.

@mayeut mayeut merged commit 5cdddb2 into pypa:main Nov 9, 2024
24 checks passed
@mayeut mayeut deleted the better-error-pypy-install branch November 14, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants