Performance minded with some bug fixes #6311
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
force-pushed
the
performance-study
branch
from
e70596f
to
5b7f839
Compare
matteius
changed the title
oz123
requested changes
Nov 10, 2024
| @@ -257,12 +257,6 @@ def python(self) -> str: | |||
|
|
|||
| @cached_property | |||
| def sys_path(self) -> list[str]: | |||
| """ | |||
There was a problem hiding this comment.
We made a terrible mistake in the python community remove docstrings in favor of annotations.
At list leave us with "The system path inside the environment" so we know that attribute is.
Also, if something is a list, one can consider calling it "sys_paths".
| @@ -689,27 +750,6 @@ def _parse_pipfile( | |||
| # Fallback to toml parser, for large files. | |||
| return toml.loads(contents) | |||
|
|
|||
| def _read_pyproject(self) -> None: | |||
There was a problem hiding this comment.
I am not sure why this was introduced, but is it OK to simply remove it?
| def _release_file_lock(self, file_obj): | ||
| """Release lock on an existing file object""" | ||
| if sys.platform == "win32": | ||
| import msvcrt |
There was a problem hiding this comment.
This import block is repeated in _acquire_file_lock and in _relase lock. Consider moving to the top.
| packages = { | ||
| k: v | ||
| for k, v in self.parsed_pipfile.get(section, {}).items() | ||
| if is_vcs(v) or is_vcs(k) |
There was a problem hiding this comment.
How are VCS packages handeled now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Testing against the sentry requirements file profiling from a fresh virtualenv creation with no Pipfile/Pipfile.lock: https://raw.githubusercontent.com/getsentry/sentry/refs/heads/master/requirements-base.txt
Main branch:
This branch:
The fix
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.