Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diminish the severity of renaming ErrorCodes enum members #3202

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Feb 6, 2025

Follow up to #3166, I think breaking is not accurate because ErrorCode is neither exported nor returned anywhere public.

(this is a kind of unnecessary change but I figure better not make people think the next release has what we would consider a breaking change. I'm fine if we decide to keep it as is.)

@A5rocks A5rocks force-pushed the no-breaking-change branch from 705bb34 to d359e70 Compare February 6, 2025 15:48
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00000%. Comparing base (8a7674c) to head (d359e70).
Report is 2 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3202   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             124          124           
  Lines           18792        18792           
  Branches         1268         1268           
===============================================
  Hits            18792        18792           

@jakkdl jakkdl added this pull request to the merge queue Feb 6, 2025
Merged via the queue into python-trio:main with commit a9f8abd Feb 6, 2025
39 checks passed
@A5rocks A5rocks deleted the no-breaking-change branch February 9, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants