PEP 774: Add Discussions-To link and minor revisions #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savannahostrowski
changed the title
AA-Turner
approved these changes
Jan 28, 2025
peps/pep-0774.rst
Outdated
| @@ -1,6 +1,7 @@ | |||
| PEP: 774 | |||
| Title: Removing the LLVM requirement for JIT builds | |||
| Author: Savannah Ostrowski <[email protected]> | |||
| Discussions-To: https://discuss.python.org/t/pep-774-removing-the-llvm-requirement-for-jit-builds/78548 | |||
There was a problem hiding this comment.
You could use the slightly shorter link here, and add a trailing comma to reduce the diff for any future threads (the trailing comma is removed on render)
Suggested change
| Discussions-To: https://discuss.python.org/t/pep-774-removing-the-llvm-requirement-for-jit-builds/78548 | |
| Discussions-To: https://discuss.python.org/t/78548/, |
There was a problem hiding this comment.
@savannahostrowski Oops, sorry! I got mixed up with Post-History, which does accept trailing commas -- unlike Discussions-To.
To that point, if you make any further PRs updating the PEP, please could you add Post-History? It's probably not worth a standalone PR though.
Co-authored-by: Adam Turner <[email protected]>
|
Wrong PEP number. :) |
hugovk
changed the title
|
...and here I thought it was neat that we had 744 and 774 😵💫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 123: Summary of changes)📚 Documentation preview 📚: https://pep-previews--4236.org.readthedocs.build/