Skip to content

Commit

Permalink
Fix package.json engine semver ranges (node.js >=8.9 <13, yarn >=1 <2) (
Browse files Browse the repository at this point in the history 
#2454)

* Allow node.js 8.9 engine compatibility

8.16 is somewhat arbitrary as far as I can tell, so this allows earlier 8.x releases of node.js as the engine so that 8.9, 8.10, 8.12, etc from Ubuntu 18.04 LTS can install this package.

#2228

* restrict to compatible yarn engine versions

Co-Authored-By: Jake Niemiec <[email protected]>

* restrict to compatible node engine versions

As 13 has been released, an upper limit is prudent as well.

Co-Authored-By: Jake Niemiec <[email protected]>

Co-authored-by: Jake Niemiec <[email protected]>
  • Loading branch information
@jbielick @jakeNiemiec
jbielick and jakeNiemiec authored Feb 10, 2020
1 parent 0b550a0 commit f3a107d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"lib/install/config/webpacker.yml"
],
"engines": {
"node": ">=8.16.0",
"yarn": ">=1.0.0"
"node": ">=8.9 <13",
"yarn": ">=1 <2"

This comment has been minimized.

Sign in to view

Copy link
@bonflintstone

bonflintstone Feb 11, 2020

Just for your information, we pinned down an error in our heroku deploys with the following message to this commit:

Gem::Requirement::BadRequirementError: Illformed requirement [">=1 <2"]
/home/bonflintstone/.rvm/gems/ruby-2.5.7/bundler/gems/webpacker-07a62a9dfed3/lib/tasks/webpacker/check_yarn.rake:11:in `new'
/home/bonflintstone/.rvm/gems/ruby-2.5.7/bundler/gems/webpacker-07a62a9dfed3/lib/tasks/webpacker/check_yarn.rake:11:in `block (2 levels) in <top (required)>'
/home/bonflintstone/.rvm/gems/ruby-2.5.7/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
/home/bonflintstone/.rvm/gems/ruby-2.5.7/bin/ruby_executable_hooks:24:in `eval'
/home/bonflintstone/.rvm/gems/ruby-2.5.7/bin/ruby_executable_hooks:24:in `<main>'
Tasks: TOP => webpacker:check_yarn

This comment has been minimized.

Sign in to view

Copy link
@jakeNiemiec

jakeNiemiec Feb 11, 2020

Author Member

This is essentially my fault, thank you for pointing this out. I have some changes on the way that will allow webpacker to read semver ranges from package.json.

This comment has been minimized.

Sign in to view

Copy link
@jakeNiemiec

jakeNiemiec Feb 12, 2020

Author Member

#2458
},
"dependencies": {
"@babel/core": "^7.7.2",
Expand Down

0 comments on commit f3a107d

Please sign in to comment.