Skip to content

Commit

Permalink
Hotfix for memcached noreply flag + bump version (#363)
Browse files Browse the repository at this point in the history
Co-authored-by: Kevin Yan <[email protected]>
  • Loading branch information
yankevn and Kevin Yan authored Oct 11, 2024
1 parent 609a77d commit 121b6cf
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion deltacat/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

deltacat.logs.configure_deltacat_logger(logging.getLogger(__name__))

__version__ = "1.1.23"
__version__ = "1.1.24"


__all__ = [
Expand Down
4 changes: 2 additions & 2 deletions deltacat/io/memcached_object_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,9 @@ def delete_many(self, refs: List[Any], *args, **kwargs) -> bool:
total_refs += len(current_refs)
try:
# always returns true
client.delete_many(current_refs, no_reply=self.noreply)
client.delete_many(current_refs, noreply=self.noreply)
fully_deleted_refs += len(current_refs)
except Exception:
except BaseException:
# if an exception is raised then all, some, or none of the keys may have been deleted
logger.warning(
f"Failed to fully delete refs: {current_refs}", exc_info=True
Expand Down
2 changes: 1 addition & 1 deletion deltacat/io/s3_object_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def delete_many(self, refs: List[Any], *args, **kwargs) -> bool:
try:
s3_utils.delete_files_by_prefix(self.bucket, str(ref))
num_deleted += 1
except Exception:
except BaseException:
logger.warning(f"Failed to delete ref {ref}!", exc_info=True)
end = time.monotonic()

Expand Down

0 comments on commit 121b6cf

Please sign in to comment.