Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCS FT] More validations for configuring GCS FT with envs and annotations #2772

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[GCS FT] More validations for configuring GCS FT with envs and annotations #2772

wants to merge 1 commit into from

Conversation

rueian
Copy link
Contributor

@rueian rueian commented Jan 18, 2025 •
edited
Loading

Why are these changes needed?

Follow-ups for #2696 (comment).

Complete TODOs for GCS FT validations.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@rueian rueian marked this pull request as ready for review January 18, 2025 20:29
@rueian rueian mentioned this pull request Jan 18, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rueian