[Refactor] Fix ruff rule E721: type-comparison #49919
Open
+55
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
win5923
requested review from
hongpeng-guo,
justinvyu,
matthewdeng,
raulchen,
woshiyyya,
sven1977,
simonsays1980 and
a team
as code owners
26 tasks
aslonnie
reviewed
Jan 18, 2025
Comment on lines
47
to
+48
| assert ( | ||
| type(params) == list | ||
| type(params) is list |
There was a problem hiding this comment.
shouldn't line 46 just declar params as type List? @sven1977 ?
|
please resolve merge conflict. |
aslonnie
reviewed
Jan 18, 2025
Signed-off-by: win5923 <[email protected]>
|
Done! |
win5923
commented
Jan 19, 2025
Comment on lines
+2596
to
+2605
| if type(channel) is CachedChannel: | ||
| channel_details += f", {channel._channel_id[:6]}..." | ||
| # get inner channel | ||
| if ( | ||
| type(channel) == CompositeChannel | ||
| type(channel) is CompositeChannel | ||
| and downstream_actor_id in channel._channel_dict | ||
| ): | ||
| inner_channel = channel._channel_dict[downstream_actor_id] | ||
| channel_details += f"\n{type(inner_channel).__name__}" | ||
| if type(inner_channel) == IntraProcessChannel: | ||
| if type(inner_channel) is IntraProcessChannel: |
There was a problem hiding this comment.
Should this be changed to isinstance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Unlike a direct type comparison,
isinstancewill also check if an object is an instance of a class or a subclass thereof.If you want to check for an exact type match, use
isoris not.Ref: https://docs.astral.sh/ruff/rules/type-comparison/
Related issue number
#47991
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.