Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use asdf for system packages #173

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Use asdf for system packages #173

merged 2 commits into from
Nov 21, 2022

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Nov 19, 2022

We've talked about checking in the asdf configuration file for explicit
version management of system dependencies in the past. This is a lightweight
version of that that gives an explicit way to get started. Using asdf locally
is out of the scope of documentation here, it's a system level dependency.


📚 Documentation preview 📚: https://read-the-docs-site-community--173.com.readthedocs.build/en/173/

We've talked about this change in the past, checking in the `asdf`
configuration file for explicit version management of system
dependencies.
@agjohnson agjohnson requested a review from a team as a code owner November 19, 2022 20:23
@agjohnson
Copy link
Contributor Author

When we talked about this one, @humitos raised issues about .tool-versions changing suddenly. This could be a problem, though with a repository configuration that uses NPM and Poetry, the system dependencies can change underneath without affecting the installed dependencies.

You will need to specify the ``FONTAWESOME_NPM_AUTH_TOKEN`` environment variable
before installing Node dependenvies. You should be using ``direnv`` locally for
secret management and encryption. Ask for this token, it's private.
You will need the following requirements:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is related to #172, the token is not required because we're using a hosted kit.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

It would be good if .tool-versions has a way to specify 3.10.x so, any patch version that you have installed works. Otherwise, we will end up with multiple 3.10 versions installed locally. It's not a problem, of course, just a nice to have 😄

@agjohnson
Copy link
Contributor Author

Yeah, I wish there was some concept of version selection like that in asdf. There are a few issues, like asdf-vm/asdf#352, that discuss some maybe options, but seems this feature was specifically ruled out.

At least with poetry abstracting the Python version a little, it's mostly just wasting the space for each Python core installation, but even a bare installation is about 250MB per install :/

@agjohnson agjohnson merged commit cbb420a into main Nov 21, 2022
@stsewd stsewd deleted the agj/use-asdf branch February 1, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants