Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): handle exceptions when creating dask cluster #618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alputer
Copy link
Member

@Alputer Alputer commented Nov 28, 2024

Closes #617

@Alputer Alputer self-assigned this Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 24.56140% with 43 lines in your changes missing coverage. Please review.

Project coverage is 75.45%. Comparing base (7896c61) to head (0eecea0).

Files with missing lines Patch % Lines
reana_workflow_controller/dask.py 23.63% 42 Missing ⚠️
reana_workflow_controller/consumer.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
- Coverage   76.61%   75.45%   -1.16%     
==========================================
  Files          17       17              
  Lines        1847     1874      +27     
==========================================
- Hits         1415     1414       -1     
- Misses        432      460      +28     
Files with missing lines Coverage Δ
reana_workflow_controller/k8s.py 88.88% <ø> (+5.06%) ⬆️
reana_workflow_controller/consumer.py 55.76% <50.00%> (+0.55%) ⬆️
reana_workflow_controller/dask.py 62.20% <23.63%> (-14.17%) ⬇️

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Nov 28, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Nov 28, 2024
@Alputer Alputer changed the title fix(k8s): handle 409 conflict errors for dask resources fix(k8s): handle exceptions when creating dask cluster Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

dask: correctly handle failure to start workflow
1 participant