Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ByteTrack: Remove BaseTrack, refactor, add types, remove dead code, moved out Shared Kalman #1603

Merged
merged 10 commits into from
Nov 1, 2024

Conversation

LinasKo
Copy link
Contributor

@LinasKo LinasKo commented Oct 17, 2024

Description

The code of ByteTrack is messy and hard to read. I've given it some attention to bring it closer to our repo standards. Behaviour is identical to previous iteration.

The primary goal is more clarity.

  • Moved STrack to single_object_track.py
  • Moved out all class variables, shared among instances of STrack, causing potential clashes between different ByteTrack instances. In this case - that's the shared Kalman.
  • Clarified a few variable names and types

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Colab: https://drive.google.com/file/d/1vloWTAb0nylZNm7CU7pXONh2pKUbVc2w/view?usp=sharing

Any specific deployment considerations

Notify others working on tracker about conflicts.

Docs

  • Docs updated? What were the changes:

@LinasKo
Copy link
Contributor Author

LinasKo commented Oct 18, 2024

Hey @onuralpszr, I'm adding you as an optional reviewer.
Feel free to have a look if you have the time and motivation.

@LinasKo LinasKo force-pushed the feat/refactor-byte-track branch from 38fb432 to 9eee76a Compare November 1, 2024 18:36
@LinasKo LinasKo changed the title ByteTrack: Remove BaseTrack, refactor, add types, remove dead code, scope shared Kalman ByteTrack: Remove BaseTrack, refactor, add types, remove dead code, moved out Shared Kalman Nov 1, 2024
@LinasKo LinasKo merged commit 1f610d8 into develop Nov 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants