Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression where all uninitialized tracks are connected #1642

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

LinasKo
Copy link
Contributor

@LinasKo LinasKo commented Nov 1, 2024

Description

Apparently, external track ID must start with 1 and not 0.
I introduced the regression when refactoring how IDs are stored and generated inside ByteTrack, somewhere around Commit #4a7d9cea.

If this is not true, when minimum_consecutive_frames > 1, all objects where no traces are established get assigned an ID of 0, and are connected with a single trace. A bit odd. Not sure where this coupling comes from.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Colab

Any specific deployment considerations

None

Docs

  • Docs updated? What were the changes:

* Apparently, external track ID must start with `1` and not `0`. Not sure where this coupling comes from.
@LinasKo
Copy link
Contributor Author

LinasKo commented Nov 1, 2024

Regression:

people-walking-out.mp4

Fixed:

people-walking-out.2.mp4

Edit: if this doesn't load, you can generate the same videos in the Colab.

@LinasKo LinasKo merged commit 589d4f9 into develop Nov 1, 2024
11 checks passed
@LinasKo LinasKo deleted the fix/tracker-regression-all-objects-connected branch November 1, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant