Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyntcore: Add repr for entries and topics #135

Merged
merged 3 commits into from
Jan 19, 2025
Merged

pyntcore: Add repr for entries and topics #135

merged 3 commits into from
Jan 19, 2025

Conversation

auscompgeek
Copy link
Member

@auscompgeek auscompgeek commented Jan 11, 2025

Open questions:

  • should the repr quote the key? i.e. <IntegerTopic '/int'>
    • teams might include weird things in their keys, in particular keys containing > might make it difficult to read nested reprs
  • should Topic et al's reprs include the ntcore module name?
    • technically it's possible to subclass the base Topic class (so it could be wrong), but not in a meaningful way

Copy link
Member

@virtuald virtuald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't think you need to quote the keys, they're just for debugging purposes anyways.

@auscompgeek
Copy link
Member Author

they're just for debugging purposes anyways

Yeah, I just wanna optimise for readability here.

@auscompgeek auscompgeek merged commit b138927 into main Jan 19, 2025
28 checks passed
@auscompgeek auscompgeek deleted the nt-topic-repr branch January 19, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants