ux improvements #37
Draft
ux improvements #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtuald
reviewed
Nov 13, 2023
| @@ -0,0 +1,4 @@ | |||
| # file generated by setuptools_scm | |||
There was a problem hiding this comment.
Probably should add this to .gitignore
virtuald
reviewed
Nov 13, 2023
| from .progress import progress | ||
| except (ImportError, ModuleNotFoundError): | ||
| print("Installing robotpy dev requirements...") | ||
| subprocess.check_call( |
There was a problem hiding this comment.
Definitely do not install the requirements automatically. Just detect the first import error and output the appropriate command for the user to copy/paste, but do not execute it.
virtuald
reviewed
Nov 13, 2023
| @@ -4,6 +4,12 @@ | |||
|
|
|||
| [params] | |||
|
|
|||
| parallel = true | |||
There was a problem hiding this comment.
I'm concerned about these interacting poorly with CI. Maybe have a user-specific file that is added to .gitignore instead?
There was a problem hiding this comment.
The default should be parallel.
Also, if ci sets an environment variable, this won't override it.
Cache should also be on by default imo. But I do need to check if ccache is available and not use it if it doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --only flag - work with a single project, ignore dependencies
Add --till flag - work with a project and its dependencies
Make rdev install its dependencies instead of erroring out
Make rdev install robotpy build instead of erroring out
Add progress bar
This is buggy for some reason. It worked on allrobotpy. But here, the progress bar keeps getting reprinted and doesn't just show up once at the bottom of the screen.