Create HTTP Post #16
Merged
Create HTTP Post #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronanrodrigo
commented
Jan 15, 2018
| @@ -0,0 +1,15 @@ | |||
| import Foundation | |||
|
|
|||
| struct BodyBuilder: BodyBuildable { | |||
There was a problem hiding this comment.
Create tests for this struct
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 20 +8
Lines 163 240 +77
Branches 11 16 +5
=====================================
+ Hits 163 240 +77
Continue to review full report at Codecov.
|
ronanrodrigo
commented
Jan 15, 2018
| } | ||
|
|
||
| private func runTask<Entity: Decodable>(with request: URLRequest, onComplete: @escaping (Result<Entity>) -> Void) { | ||
| let task = urlSession.dataTask(with: request) { data, _, error in |
There was a problem hiding this comment.
Extract this to avoid duplication. Is the same at NetworkGet.
… expression type check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of issue #8 implementing POST method.
NetworkPostclass;NetworkPostTests.