-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for release 0.6.0 #92
Conversation
svd2rust is about to change the default case for fields, methods and types (see rust-embedded/svd2rust#805). But maybe we should get 0.6 done and put that change in 0.7? |
Yes, I heard about it moments after sending the merge request. If we want to do that change (l hope it's optional?) we should IMHO wait for it. |
They changed the default. You can use a config file to put it back as it was. But it's a good change! The defaults were just wrong and confusing to teach. |
I rebuilt the pac using the updated svd2rust, and I agree, the new identifier casing is more consistent. One disadvantage I see is that the old spelling was usually identical to what's used in the datasheets, so it was easier to cross-reference between documentation and code. Anyway, this is a huge breaking change. Trying to compile an unmodified rp2040-hal with that pac ends with:
|
|
Worse, it breaks applications that do |
If you would like to include svd2rust's new naming scheme in pac v0.6.0, I am willing to help. However, I suspect that the release will take some time, as they will be cautious about releasing it with major changes to svd2rust. |
svd2rust 0.32 is released. Or use |
No description provided.