4976 product drive participant dropdown fix #4997
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down when no business name is available
cielf
requested changes
Feb 11, 2025
There was a problem hiding this comment.
Hey @tbenny001 -- Thanks for taking this on!
At first it looked pretty good, but I tried the following sequence, and the blanks came back.
First I tried adding through the community|product drive participants -- looked good! --
Then I tried adding the product participant without a business name through the "Create New Participant" on the product participant field in New Donation. When I did that, the product participant was blank, and the product participants without business names were blank in the drop down when I looked at it
I'm sure it's something simple that just needs to be tweaked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4976
Description
When creating a new donation and choosing Product Drive as the source, the Product Drive Participant drop down displays a blank entry when the participant has no business name. This PR addresses this issue by falling back to the contact name of the product drive participant if the participant does not have a business name.
Also adding DockerDesktopWSL/ to the .gitignore file
Type of change
How Has This Been Tested?
New Rspec tests and manual verification
Screenshots
Creating a Product Drive Participant with no business name:
Before:
After:
