Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to ignore specific Gemfile groups #228

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fatkodima
Copy link
Contributor

Algorithm:

  1. get all groups from Gemfile (gemfile.groups)
  2. remove ignored groups from the above (groups_to_check)
  3. get all gem specifications for gems in groups to check (parent_dependencies)
  4. using breadth-first search, get the remaining gem specifications

Closes #195

@fatkodima
Copy link
Contributor Author

ping @postmodern @reedloden

@postmodern
Copy link
Member

FYI, in the 0.8.0 branch (soon to be merged/released) support for a .bundle-audit.yml configuration file was added with support for a ignore: key to ignore individual advisories by ID.

I'm hesitant about ignoring whole groups, as that could allow vulnerabilities to go un-patched/un-mitigated; attackers don't care if a vulnerable gem is only activated during development if they can still somehow exploit it. Ignoring by individual advisory, where you confirm that you've mitigated it somehow, is much safer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Allow group selection
2 participants