fix: Add pagination to AzureDevops modified files call

[bub3n]

what

• enable to get more files from Azure DevOps diff endpoint (and don't change default behavior)
• more info about this here: Atlantis plans less projects than anticipated by modified files  #4858
• we also forked https://github.com/drmaxgit/go-azuredevops from https://github.com/mcdafydd/go-azuredevops because the repo seemed abandoned. There was also github issue regarding this problem which was not even answered.

why

• At our company we use Atlantis for terraform automatization, we bumped into the problem if we have lots of changes across multiple projects that Atlantis is not planning all of them

tests

• I have tested it in our stack
• also I fixed test and I was able to run make test without any errors

references

• closes Atlantis plans less projects than anticipated by modified files  #4858
• https://learn.microsoft.com/en-us/rest/api/azure/devops/git/diffs/get?view=azure-devops-rest-5.1&tabs=HTTP

[jamengual]

@bub3n Thanks for the PR. Could you write some tests for this?

Thanks.

[bub3n]

@jamengual sure, I'll prepare something

[bub3n]

@jamengual Tried to add test for new client with top and skip arguments.

Idea behind this is to test client without and with the behavior so we know if it won't break the default setup

[X-Guardian]

Hi @bub3n, I started to have a look at this PR, but it looks like you have got a lot of unrelated changes committed. Can you review these and remove anything unrelated to the description in the PR. Thanks.

[bub3n]

Yeah, my bad. Working on a fix. Sorry for troubles

[X-Guardian]

No problem. I assume this fixes the pagination of the relevant Azure DevOps API call, but I don't think we need additional server parameters to adjust the pagination. We are trying to avoid adding server parameters that aren't necessary.

[bub3n]

@X-Guardian unfortunately it does not. I guess you are right, my bad. I'll rework it for pagination.

BTW what number of elements would you say is good per "page"? 100 which is their API default?

[X-Guardian]

Yes, I'm sure the default will be fine.

[bub3n]

Hello again, sorry for previous problems caused.

This time I tried to prepare it so it uses the pagination. I also fixed the test. And I ran make test which was fine. Also I tested it on our infra if everything seems okay. And Atlantis plan went fine and with more changes (as expected for the commit).

[X-Guardian]

No problem @bub3n. Good to see Azure DevOps getting some love.

Some linting and formatting fixes needed.

Can you also update the PR title to more accurately describe the change? (This is used for the changelog entry)

[bub3n]

Sure, I'll fix it. Thx for the feedback.

[lukemassa]

I recently merged #5309 which caused a conflict here. I'm happy to fix it, or you can if you want (it's just the err check has to move down a bit to right after the call to GetDiffs)

[bub3n]

@lukemassa please fix it if you don't mind. I'll try to fix the linting problems.