Fix SmolStrBuilder::push pushing null bytes on heap spill
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
changed the title
SmoLStrBuilder::push pushing null bytes on heap spillSmolStrBuilder::push pushing null bytes on heap spill
Enselic
added a commit
to cargo-public-api/cargo-public-api
that referenced
this pull request
Oct 25, 2024
Our CI is currently failing because smol_str yanked 0.3.1. But it only had a regular bug, not undefined behavior or a security hole: rust-analyzer/smol_str#89 I don't want our CI to fail because of this, so let's allow yanked crates. If a crate has a known security vulnerability, other cargo-deny rules will catch it.
Enselic
added a commit
to cargo-public-api/cargo-public-api
that referenced
this pull request
Oct 25, 2024
Our CI is currently failing because smol_str yanked 0.3.1. But it only had a regular bug, not undefined behavior or a security hole: rust-analyzer/smol_str#89 I don't want our CI to fail because of known regular bugs, so let's allow yanked crates. If a crate has a known security vulnerability, other lint rules will catch it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88