Improve support for BigInt, enhance union type

[opti]

• Add ranges for int and bigint according to specs.
  This fix allows handling situations where int and long are present and covers issues like:

  Avro::IO::AvroTypeError: The datum 3324284763061284583 is not an example of schema "int"

• Enhance union type selection during the serialization. Previously, we only checked the value class (now additionally for the union types index picking check if the value is coercible with a particular type)

[opti]

Not sure why Linter is complaining. There is no changes in lib/avromatic/model/raw_serialization.rb:19:9 in this PR.

Inspecting 94 files
.......................C......................................................................

Offenses:

lib/avromatic/model/raw_serialization.rb:19:9: C: Style/AccessModifierDeclarations: private should not be inlined in method definitions.
        private :datum_writer, :datum_reader
        ^^^^^^^

94 files inspected, 1 offense detected

Exited with code exit status 1

[erikkessler1]

Not sure why Linter is complaining. There is no changes in lib/avromatic/model/raw_serialization.rb:19:9 in this PR.

I'd guess a new version of RuboCop got used that changed how it it applies that rule. You could add # rubocop:disable Style/AccessModifierDeclarations to that line since it seems like a false positive.

[erikkessler1]

Thank you for working on this! It certainly seems like a gap.

A question I have is if we can remove the #matched? in favor of special casing integer handling in UnionType#find_index since we really only need matched? for integers.

[erikkessler1]

This can be a hot code path, so it would be nice to be able to cache this index lookup (i.e., build a cache from value.class to union_index). With this change, since we match on the value itself, that cache isn't possible.

Additionally, the matched? call adds overhead for all types, but we only need it for the case where value.is_a?(Integer). What do you think about special casing integer handling here?

def find_index(value)
  if value.is_a?(::Integer)
    if Avromatic::Model::Types::IntegerType.in_range?(value)
      member_types.index(Avromatic::Model::Types::IntegerType)
    end || if Avromatic::Model::Types::BigIntType.in_range?(value)
      member_types.index(Avromatic::Model::Types::BigIntType)
    end
  else
    # TODO: Cache this
    member_types.find_index do |member_type|
      member_type.value_classes.any? { |value_class| value.is_a?(value_class) }
    end
  end
end